Add monitoring to devcontainer startup #268
Conversation
june-hua
force-pushed
the
PHP-89928-metrics
branch
from
ea38b47 to
758981e
Compare
|
|
||
|
|
||
| case "${SERVER}" in | ||
| "dev-stable") echo "https://workbench-dev.verily.com/api/${SERVER}" ;; |
There was a problem hiding this comment.
Should these be
| "dev-stable") echo "https://workbench-dev.verily.com/api/${SERVER}" ;; | |
| "dev-stable") echo "https://workbench-dev.verily.com/api/${1}" ;; |
|
|
||
| MONITORING_UTILS_FILE="/home/core/monitoring-utils.sh" | ||
| FIRST_BOOT_START_FILE="/home/core/first-boot-start" | ||
| if [[ -f "${MONITORING_UTILS_FILE}" && ! -f "${FIRST_BOOT_START_FILE}" ]]; then |
There was a problem hiding this comment.
Just curious, do we expect cases where the monitoring-utils file doesn't exist?
| function get_service_url() { | ||
| SERVER="$(get_metadata_value "terra-cli-server" "")" | ||
| if [[ -z "${SERVER}" ]]; then | ||
| SERVER="dev-stable" |
There was a problem hiding this comment.
Should this be prod?
|
|
||
| source /home/core/service-utils.sh | ||
|
|
||
| WORKSPACE_ID="$(get_metadata_value "terra-workspace-id" "")" |
| && docker ps -q --filter "name=application-server" | grep -q .; then | ||
| echo "Proxy is ready." | ||
| status="$(get_guest_attribute "startup_script/status" "")" | ||
| success=0 |
There was a problem hiding this comment.
nit: status_code since it's not just success
There was a problem hiding this comment.
so 0 is success and 1 is failure?
i'm little confused because devcontainer start is passing in success:1
| payload=$(cat <<EOF | ||
| { | ||
| "state": "DEVCONTAINER_END", | ||
| "success": ${SUCCESS} |
There was a problem hiding this comment.
is it too late to change this to status too?
| echo "VM state recorded successfully: ${response_body}" | ||
| } | ||
|
|
||
| function record_devcontainer_start() { |
There was a problem hiding this comment.
can we refactor the two method to calls function log_event() and pass in payload?
| payload=$(cat <<EOF | ||
| { | ||
| "state": "DEVCONTAINER_START", | ||
| "success": 1 |
There was a problem hiding this comment.
In the openapi in your add endpoint PR this is a boolean, will it map correctly?
There was a problem hiding this comment.
Haven't been able to test this locally yet, will be checking that this works properly!
| # First boot file does not exist | ||
| # Record startup begin for monitoring | ||
| source "${MONITORING_UTILS_FILE}" | ||
| record_devcontainer_start "${CLOUD_PLATFORM}" |
There was a problem hiding this comment.
does it take in CLOUD_PLATFORM?
No description provided.